chore: finish removing pip_repository_annotations#3684
chore: finish removing pip_repository_annotations#3684rickeylev merged 2 commits intobazel-contrib:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the pip_repository_annotations example by deleting its BUILD.bazel file and test script, and updating the .bazelrc.deleted_packages configuration. Feedback indicates that the removal is incomplete, as orphaned files and directories such as requirements.in and data/ were not included in the deletion.
| @@ -1,38 +0,0 @@ | |||
| load("@rules_python//python:pip.bzl", "compile_pip_requirements") | |||
There was a problem hiding this comment.
The removal of the BUILD.bazel file and the test script is correct for decommissioning this example. However, there are other files and directories referenced in this file that do not appear in the deletion list of this PR, specifically:
requirements.in(referenced on line 12)- The
data/directory (referenced on line 5) - Potentially a
requirements.txtor lockfile generated bycompile_pip_requirements.
To fully 'finish removing' the example as stated in the PR title, please ensure these orphaned files are also deleted from the repository if they still exist.
2 participants
It looks like it was only partially deleted. Enough that the deleted packages
updater was trying to un-deleted it from the deleted packages list because its
WORKSPACE and MODULE files were removed.